nathan/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2026-10-02 04:50:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

workflows/codeowners: Dry mode for now

Browse Source 
Apparently it started requesting reviews from code owners already
because the DRY_MODE from the global env was overridden in the local job
declaration: https://github.com/NixOS/nixpkgs/pull/347354#event-14570645380

(cherry picked from commit c1710f234c)
This commit is contained in:
Silvan Mosberger
2024-10-09 18:34:34 +02:00
parent 2e923fb2f6
commit bbd64b4b69
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
.github/workflows/codeowners.yml vendored
View File

@@ -15,11 +15,12 @@ on:
env:
# TODO: Once confirmed that this works by seeing that the action would request
# reviews from the same people (or refuse for wrong base branches),
# move all entries from CODEOWNERS to OWNERS and change this value here
# OWNERS_FILE: .github/OWNERS
# move all entries from CODEOWNERS to OWNERS, remove these two lines and uncomment the ones below
OWNERS_FILE: .github/CODEOWNERS
# Also remove this
DRY_MODE: 1
# OWNERS_FILE: .github/OWNERS
# # Don't do anything on draft PRs
# DRY_MODE: ${{ github.event.pull_request.draft && '1' || '' }}
jobs:
# Check that code owners is valid
@@ -84,5 +85,3 @@ jobs:
run: result/bin/request-reviews.sh ${{ github.repository }} ${{ github.event.number }} "$OWNERS_FILE"
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
# Don't do anything on draft PRs
DRY_MODE: ${{ github.event.pull_request.draft && '1' || '' }}